Skip to content

dynamic page height and sync version number - #32

Closed
jimmckeeth wants to merge 3 commits into
Bharath-code:mainfrom
jimmckeeth:main
Closed

dynamic page height and sync version number#32
jimmckeeth wants to merge 3 commits into
Bharath-code:mainfrom
jimmckeeth:main

Conversation

@jimmckeeth

@jimmckeeth jimmckeeth commented Jun 21, 2026

Copy link
Copy Markdown

Description

  • 🐛[fix] Synchronized version numbers so they are all the same: 1.3.2
    • nudge.go and view.go showed 1.3.0 but main.go still had 1.0.1 so git-scope -v returned 1.0.1 while the header showed 1.3.0
    • Now all use internal/version/version.go to prevent drift
    • The code showed version 1.3.0 but the latest release said 1.3.1 so I went with 1.3.2.
  • ✨ [new] Repo list now fills the full available terminal height instead of a fixed page size
  • ✨ [new] Page size adjusts automatically on terminal resize, search bar open/close, and filter/sort changes
  • 🔧 [change] Removed pageSize config option - it didn't work consistently, and is the wrong approach since the terminal window size can change. Now page size is determined entirely by terminal height

Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
    • Technically I took out the old pageSize config option
  • 📚 Documentation update
  • 🔧 Refactoring (no functional changes)

Checklist

  • I have tested my changes locally
  • I have updated the documentation (if applicable)
  • My code follows the project's style guidelines
  • I have added tests that prove my fix/feature works (if applicable)

Screenshots (if applicable)

image

@kilo-code-bot

kilo-code-bot Bot commented Jun 21, 2026

Copy link
Copy Markdown

Kilo Code Review could not run — your account is out of credits.

Add credits or switch to a free model to enable reviews on this change.

@Bharath-code

Bharath-code commented Sep 26, 2026

Copy link
Copy Markdown
Owner

Thanks a lot for this, @jimmckeeth, and sorry it sat for so long!

Both parts of this PR have since landed on main in other forms, so I'm closing it:

  • Dynamic page height: shipped in v1.4.0 (feat: dynamically adjust page size based on terminal height #21). The list fills the available terminal height and recalculates on resize and when the search bar opens or closes, the same idea as yours.
  • Version sync: the version is now injected at release time via -ldflags "-X main.version=…" and passed to the nudge, so there's no hardcoded version left to drift. git-scope -v always matches the release tag.

Your point about pageSize is still valid: the config option is effectively dead now that height drives page size. I'll remove it in a follow-up and credit you for spotting it.

Thanks again, and contributions are always welcome!

Bharath-code added a commit that referenced this pull request Sep 26, 2026
@Bharath-code @claude
chore(config): remove dead pageSize option
a576cf6 
Page size follows terminal height since #21, so the config value was
overwritten on the first resize. Old configs with pageSize still load;
the key is ignored. Flagged in #32.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jimmckeeth @Bharath-code